mirror of
https://github.com/docmost/docmost.git
synced 2026-08-29 10:05:03 +08:00
Philipinho
79394f93f5
Base file-cell uploads were hitting a parallel POST /bases/files/upload endpoint that re-implemented the multipart parse, the size limit handling, and the spaceId resolution that the standard page-attachment endpoint (POST /files/upload) already does. The two diverged on minor points (no audit log, no attachmentId support, slightly different permission check) without good reason — bases are pages (isBase=true), so the existing endpoint already handles them correctly. Server: delete uploadBaseFile and the now-unused BaseRepo injection. Client: route the file-cell uploader through the existing uploadFile helper in page-service. The base's pageId is a valid page id, so the server's pageRepo.findById succeeds and pageAccessService.validateCanEdit runs — which lines up with the Base edit ability at the space-role level (Manage Page and Manage Base track together for admins/writers, Read for readers).