From d385099eb17e4fa8ef0af1e46a018dad94b4796e Mon Sep 17 00:00:00 2001
From: Philipinho <16838612+Philipinho@users.noreply.github.com>
Date: Sat, 18 Apr 2026 21:51:43 +0100
Subject: [PATCH] fix(base): fire hide toggle once per click instead of twice

---
 .../base/components/views/view-field-visibility.tsx      | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/apps/client/src/features/base/components/views/view-field-visibility.tsx b/apps/client/src/features/base/components/views/view-field-visibility.tsx
index 495447bf..8f0be62b 100644
--- a/apps/client/src/features/base/components/views/view-field-visibility.tsx
+++ b/apps/client/src/features/base/components/views/view-field-visibility.tsx
@@ -138,6 +138,15 @@ export function ViewFieldVisibility({
                     checked={isVisible}
                     disabled={!canHide}
                     onChange={() => {}}
+                    // The Switch's <label> default-action synthesizes a
+                    // second click on its hidden <input> after the user
+                    // clicks the track. Without preventDefault, both clicks
+                    // bubble to the parent UnstyledButton and fire
+                    // handleToggle twice (hide then immediately unhide,
+                    // net zero). `preventDefault` cancels the synthesized
+                    // second click while letting the first one bubble so
+                    // UnstyledButton's onClick fires exactly once.
+                    onClick={(e) => e.preventDefault()}
                     styles={{ track: { cursor: canHide ? "pointer" : "not-allowed" } }}
                   />
                 </UnstyledButton>