short circuit sidebar permissions

apps/server/src/core/page/page.controller.ts

@@ -298,11 +298,17 @@ export class PageController {
       throw new ForbiddenException();
     }
 
+    const spaceCanEdit = ability.can(
+      SpaceCaslAction.Edit,
+      SpaceCaslSubject.Page,
+    );
+
     return this.pageService.getSidebarPages(
       spaceId,
       pagination,
       dto.pageId,
       user.id,
+      spaceCanEdit,
     );
   }
 

apps/server/src/core/page/services/page.service.ts

@@ -183,6 +183,7 @@ export class PageService {
     pagination: PaginationOptions,
     pageId?: string,
     userId?: string,
+    spaceCanEdit?: boolean,
   ): Promise<CursorPaginationResult<Partial<Page> & { hasChildren: boolean }>> {
     let query = this.db
       .selectFrom('pages')
@@ -222,9 +223,17 @@ export class PageService {
     });
 
     if (userId && result.items.length > 0) {
+      const hasRestrictions =
+        await this.pagePermissionRepo.hasRestrictedPagesInSpace(spaceId);
+
+      if (!hasRestrictions) {
+        result.items = result.items.map((p: any) => ({
+          ...p,
+          canEdit: spaceCanEdit ?? true,
+        }));
+      } else {
         const pageIds = result.items.map((p: any) => p.id);
 
-      // Single query to get accessible pages with their edit permissions
         const accessiblePages =
           await this.pagePermissionRepo.filterAccessiblePageIdsWithPermissions(
             pageIds,
@@ -235,7 +244,6 @@ export class PageService {
           accessiblePages.map((p) => [p.id, p.canEdit]),
         );
 
-      // Filter and add canEdit flag in one pass
         result.items = result.items
           .filter((p: any) => permissionMap.has(p.id))
           .map((p: any) => ({
@@ -243,8 +251,9 @@ export class PageService {
             canEdit: permissionMap.get(p.id),
           }));
 
-      // For pages with hasChildren: true, verify they have accessible children
+        const pagesWithChildren = result.items.filter(
-      const pagesWithChildren = result.items.filter((p: any) => p.hasChildren);
+          (p: any) => p.hasChildren,
+        );
         if (pagesWithChildren.length > 0) {
           const parentIds = pagesWithChildren.map((p: any) => p.id);
           const parentsWithAccessibleChildren =
@@ -252,7 +261,9 @@ export class PageService {
               parentIds,
               userId,
             );
-        const hasAccessibleChildrenSet = new Set(parentsWithAccessibleChildren);
+          const hasAccessibleChildrenSet = new Set(
+            parentsWithAccessibleChildren,
+          );
 
           result.items = result.items.map((p: any) => ({
             ...p,
@@ -260,6 +271,7 @@ export class PageService {
           }));
         }
       }
+    }
 
     return result;
   }