From 1aa92b1bb5cf448687a726efbadbe351cb594e50 Mon Sep 17 00:00:00 2001
From: Philipinho <16838612+Philipinho@users.noreply.github.com>
Date: Sat, 18 Apr 2026 21:57:28 +0100
Subject: [PATCH] fix(base): stop synthesized switch input click from re-firing
 hide toggle

---
 .../views/view-field-visibility.tsx           | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/apps/client/src/features/base/components/views/view-field-visibility.tsx b/apps/client/src/features/base/components/views/view-field-visibility.tsx
index 8f0be62b..69d90d3e 100644
--- a/apps/client/src/features/base/components/views/view-field-visibility.tsx
+++ b/apps/client/src/features/base/components/views/view-field-visibility.tsx
@@ -138,15 +138,16 @@ export function ViewFieldVisibility({
                     checked={isVisible}
                     disabled={!canHide}
                     onChange={() => {}}
-                    // The Switch's <label> default-action synthesizes a
-                    // second click on its hidden <input> after the user
-                    // clicks the track. Without preventDefault, both clicks
-                    // bubble to the parent UnstyledButton and fire
-                    // handleToggle twice (hide then immediately unhide,
-                    // net zero). `preventDefault` cancels the synthesized
-                    // second click while letting the first one bubble so
-                    // UnstyledButton's onClick fires exactly once.
-                    onClick={(e) => e.preventDefault()}
+                    // Mantine's Switch spreads `onClick` onto its hidden
+                    // <input>. When the user clicks the visible track, the
+                    // label's default action synthesizes a second click on
+                    // that input — both clicks bubble to the parent
+                    // UnstyledButton and fire handleToggle twice (hide then
+                    // immediately unhide, net zero). stopPropagation here
+                    // blocks ONLY the synthesized input click from reaching
+                    // UnstyledButton; the original track click still bubbles
+                    // normally, so handleToggle fires exactly once.
+                    onClick={(e) => e.stopPropagation()}
                     styles={{ track: { cursor: canHide ? "pointer" : "not-allowed" } }}
                   />
                 </UnstyledButton>